Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined
From: Alex Riesen <hidden>
Date: 2016-06-15 22:52:49
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined · Ævar Arnfjörð Bjarmason <hidden>
- 2016-06-15 · Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined · Alex Riesen <hidden>
- 2016-06-15 · Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined · Alex Riesen <hidden>
- 2016-06-15 · [PATCH] i18n: disable i18n for shell scripts if NO_GETTEXT defined · Alex Riesen <hidden>
On Thu, Jan 19, 2012 at 01:12, Jonathan Nieder [off-list ref] wrote:
I like the unindenting. Alas, I get 1: test: type: unexpected operator I suspect this should just say "elif type gettext.sh >/dev/null 2>&1".
Indeed. Copy-paste error. I wonder why I didn't notice it... Yes, ran the tests, both with and without NO_GETTEXT.
The rest looks good. Thanks for writing it.
Was Junios idea, I just liked it.