Thread (17 messages) flat view 17 messages, 6 authors, 2016-06-15

Re: [BUG] multi-commit cherry-pick messes up the order of commits

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:52:47

Am 12.01.2012 18:09, schrieb Ramkumar Ramachandra:
quoted hunk ↗ jump to hunk
@@ -2054,7 +2054,10 @@ int prepare_revision_walk(struct rev_info *revs)
                if (commit) {
                        if (!(commit->object.flags & SEEN)) {
                                commit->object.flags |= SEEN;
-                               commit_list_insert_by_date(commit,
&revs->commits
+                               if (revs->literal_order)
+                                       commit_list_insert(commit,
&revs->commits
+                               else
+
commit_list_insert_by_date(commit, &revs-
Why do we need a new flag?

  git show origin/master origin/maint
  git show origin/maint origin/master

show the revisions in different order, in particular, in the order
requested on the command line. Shoudn't cherry-pick be able to do the
same without new hacks?

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help