Re: git-send-email: bug with sendemail.multiedit
From: Thomas Rast <hidden>
Date: 2016-06-15 22:52:45
Jean-Francois Dagenais [off-list ref] writes:
Bonjour Pierre! ... and all git developers! I think there is a bug with git-send-email.perl's evaluation of the sendemail.multiedit config variable. I was only able to make the "do_edit()" function detect it as false by setting the variable to "0" instead of "false", like so: git config --global sendemail.multiedit 0 otherwise do_edit evaluates it as true and invokes the editor with all files as argument.
The patch below looks like the obvious fix. Perhaps you can test it?
diff --git i/git-send-email.perl w/git-send-email.perl
index d491db9..7ac0a7d 100755
--- i/git-send-email.perl
+++ w/git-send-email.perl@@ -210,6 +210,7 @@ sub do_edit { "signedoffbycc" => [\$signed_off_by_cc, undef], "signedoffcc" => [\$signed_off_by_cc, undef], # Deprecated "validate" => [\$validate, 1], + "multiedit" => [\$multiedit, undef], ); my %config_settings = (
@@ -227,7 +228,6 @@ sub do_edit { "bcc" => \@bcclist, "suppresscc" => \@suppress_cc, "envelopesender" => \$envelope_sender, - "multiedit" => \$multiedit, "confirm" => \$confirm, "from" => \$sender, "assume8bitencoding" => \$auto_8bit_encoding,
--
Thomas Rast
trast@{inf,student}.ethz.ch