Thread (6 messages) flat view 6 messages, 3 authors, 2016-06-15

Re: [PATCH 2/3] show_ref(): remove unused "flag" and "cb_data" arguments

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:44

mhagger@alum.mit.edu writes:
I suppose, though I didn't verify, that the old function signature was
a vestige of its earlier having been used as a callback function.  But
it doesn't really matter; the point is that the extra arguments are
currently not needed.
Yeah, since 8a65ff7 (Generalize the "show each ref" code in receice-pack,
2005-07-02) the function has always been fed to for_each_ref(), but when
6b01ecf (ref namespaces: Support remote repositories via upload-pack and
receive-pack, 2011-07-08) introduced show_ref_cb() as the callback that
uses show_ref() as a helper, it forgot to do the clean-up in this patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help