Re: [PATCH] attr: map builtin userdiff drivers to well-known extensions

Johannes Sixt [off-list ref] writes:

Am 12/16/2011 12:00, schrieb Jeff King:

quoted

 static const char *builtin_attr[] = {

...

quoted

+	"*.c diff=cpp",
+	"*.cc diff=cpp",
+	"*.cxx diff=cpp",
+	"*.cpp diff=cpp",
+	"*.h diff=cpp",
+	"*.hpp diff=cpp",

Please don't do this. It would be a serious regression for C++ coders, and
some C coders as well. The built-in hunk header patterns are severly
broken and don't work well with C++ code.

I do not often do C++, but I tend to agree wrt C.