Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [BUG] in rev-parse

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:39

Jeff King [off-list ref] writes:
Dropping the implied verify is easy (see below). But handling
non-existant sha1s is a much more complicated change, as the regular
abbreviation machinery assumes that they exist.
Hmm, I was very sure that I wrote a logic to do the "no such object" case
at least once, so I looked and found one in find_unique_abbrev(). But that
requires the caller to feed the full 160-bit sha1[] and perhaps it is not
easily used in the context of rev-parse (I didn't look further).
Anyway, I'm not sure it's worth changing at this point. It's part of the
plumbing API that has been that way forever,...
Ok.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help