Thread (6 messages) flat view 6 messages, 5 authors, 2016-06-15

Re: t0090-cache-tree fails due to wc whitespace

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:52:38

Am 12/14/2011 15:35, schrieb Brian Gernhardt:
It's time for my periodic complaint:  People assuming `wc -l` outputs
just a number.  wc on OS X (and perhaps other BSD-like systems) always
aligns the output in columns, even with the -l flag.  Generally this
results in a quick patch from me to remove some unneeded quotes.
However, this time it's used in a more complex manner:

	echo "SHA " \
	    "($(git ls-files|wc -l) entries, 0 subtrees)" >expect &&
	cmp_cache_tree expect
I'd solve it by moving the command substitution outside the quoted string:

 	printf "SHA (%d entries, 0 subtrees)\n" \
		$(git ls-files | wc -l) >expect &&

Other proposed solutions add another process. I don't like that on Windows ;)

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help