Re: [PATCH] test: errors preparing for a test are not special

Am 12/14/2011 9:22, schrieb Jonathan Nieder:

Johannes Sixt wrote:

quoted

Am 12/13/2011 23:35, schrieb Joe Ratterman:

quoted

quoted

 test_expect_success TTY 'no pager with --no-pager' '
 	rm -f paginated.out ||
 	cleanup_fail &&

What kind of bogosity do I see in the context of this hunk

[...]

quoted

Wouldn't rm -f always succeed under normal circumstances, and then the
rest of the test would be skipped?

No, && and || are left-associative.

<Facepalm/> You are right, of course, and I should have known better. (I
need more caffein.)

At any rate, your patch makes the code much more comprehensible.

-- Hannes