Thread (49 messages) 49 messages, 6 authors, 2016-06-15

Re: [PATCHv3 08/13] credential: make relevance of http path configurable

From: Jeff King <hidden>
Date: 2016-06-15 22:52:36

On Sat, Dec 10, 2011 at 03:50:11AM -0800, Jakub Narebski wrote:
quoted
This is nothing you couldn't do with a clever credential
helper at the start of your stack, like:

  [credential "http://"]
	helper = "!f() { grep -v ^path= ; }; f"
	helper = your_real_helper

But doing this:

  [credential]
	useHttpPath = false
Shouldn't this be 'usePath' or 'usePathComponent' or 'useRepositoryPath',
etc.?  Because if^W when remote helper for Subversion is complete, you
could have svn://svnserve.example.com/path/to/repo as an URL... which
would be not HTTP(S).
It must be per-protocol, because paths will be relevant for some
protocols (e.g., unlocking certificates in the local filesystem).
So if anything, it would be "useNetworkPath" or something, if we wanted
to unify svn and http. But it would also be OK to have a separate flag
for http and svn, which is more flexible (and most users aren't going to
set it at all, so they won't notice).

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help