Thread (9 messages) flat view 9 messages, 2 authors, 2016-06-15

Re: [PATCH 1/3] Convert resolve_ref+xstrdup to new resolve_refdup function

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:36

Nguyễn Thái Ngọc Duy wrote:
[Subject: Convert resolve_ref+xstrdup to new resolve_refdup function]
I like it.
quoted hunk ↗ jump to hunk
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -901,7 +901,7 @@ static int rollback_single_pick(void)
 	if (!file_exists(git_path("CHERRY_PICK_HEAD")) &&
 	    !file_exists(git_path("REVERT_HEAD")))
 		return error(_("no cherry-pick or revert in progress"));
-	if (!resolve_ref("HEAD", head_sha1, 0, NULL))
+	if (read_ref_full("HEAD", head_sha1, 0, NULL))
 		return error(_("cannot resolve HEAD"));
 	if (is_null_sha1(head_sha1))
 		return error(_("cannot abort from a branch yet to be born"));
Unrelated change that snuck in, I assume?

The rest of the patch looks very sensible and no-op-like. :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help