Re: [PATCH 1/2] t3401: modernize style

On Fri, Dec 9, 2011 at 12:07 PM, Jonathan Nieder [off-list ref] wrote:

Ramkumar Ramachandra wrote:

quoted

The motivation is unclear: lazy afternoon? :P

Perhaps he was reading the list and after noticing a few patches in
the same vein, realized that this test script could be made easier to
read, too.

Sort of. These patches have been sitting in my repo since late Sept
and the patches you mention made me decide to send them out now. The
reason I did this back then was while trying to fix rebase to pick the
right patches when used with --onto. See this old discussion:
http://thread.gmane.org/gmane.comp.version-control.git/161917/focus=162041.
Also in the same series are patches teach rebase to only feed the
commit names to git-am (wrapped in a silly "From $sha1 Mon
Sep 17 00:00:00 2001" to please git-mailsplit). These patches have
been taking way too long, which is why I'm sending these little
cleanups separately.

quoted

Martin von Zweigbergk wrote:

quoted

quoted

+       echo First > A &&
+       git update-index --add A &&
+       git commit -m "Add A." &&

Style nit: >[^ ] is prevalent FWIW.

Finally I caught on that you mean that redirection operators tend to
be flush against the filename they are redirecting to.

So did I. I think I'll leave the code unchanged, though, because the
end result, after patch 2/2 is unaffected anyways (it removes
redirections).

quoted

While at it, why not change this "test ! -d" to
"test_path_is_missing"?

Will bake it into patch 2/2 if you don't mind. Unless there are other
comments, that would mean this patch can be applies as is, Junio.

The patch looks good to me, too.  Thanks, both.

Thanks to you both, too.