Thread (2 messages) 2 messages, 2 authors, 2016-06-15

Re: [PATCH 1/2] run-command: Add checks after execvp fails with EACCES

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:35

"Frans Klaver" [off-list ref] writes:
quoted
Wouldn't access(2) with R_OK|X_OK give you exactly what you want without
this much trouble?
I just had a good look through the man page of access(2), and I think
it depends. access works for the real uid, which is what I attempted
to implement in the above check as well. However, do we actually need
to use the real uid or do we need the set uid (geteuid(2))?
Does it matter? We do not use seteuid or setegid ourselves and we do not
expect to be installed as owned by root with u+s bit set.

access(2) checks with real uid exactly because it would not make a
difference to normal user level programs _and_ it makes it easier for a
suid programs to check with the real identity, and our use case falls into
the former, no?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help