Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 5/6] t1510 (worktree): fix '&&' chaining

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:35

Jonathan Nieder [off-list ref] writes:
This is also not "Additionally", as in "As a separate change that
maybe should have been another patch but I am too lazy".  Rather, it
is a necessary change that is part of the same task.  So I would
write:

	Breaks in a test assertion's && chain can potentially hide failures
	from earlier commands in the chain.  Fix these breaks.

	'unset' returns non-zero status when the variable passed was already
	unset on some shells, so now that the status is tested we need to
	change these instances to 'safe_unset'.

Erm, sane_unset, not safe_unset.  Did you even test this?
Thanks for careful reading and many constructive review comments.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help