Thread (7 messages) flat view 7 messages, 3 authors, 2016-06-15

Re: [PATCH] index-pack: eliminate unlimited recursion in get_delta_base()

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:52:35

2011/12/8 Shawn Pearce [off-list ref]:
I think you missed the critical recursion. The real work is the
recursion within find_unresolved_deltas(). This little helper
get_base_data() shouldn't be tripping over these cases unless we have
run out of delta_base_cache_limit and released objects near the base
end of the delta chain, in which case this will restore them.

Maybe this is useful on its own, but in my opinion its not an
interesting patch to consider without first fixing
find_unresolved_deltas's recursion.
Thanks. I missed that function. Will try to fix it.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help