Re: [PATCH] Make feed title valid utf8
From: Jakub Narebski <hidden>
Date: 2016-06-15 22:52:32
Subject: gitweb: Make feed title valid utf8 Jürgen Kreileder [off-list ref] writes:
quoted hunk ↗ jump to hunk
gitweb doesn't properly handle UTF8 site names when generating feed titles. Signed-off-by: Juergen Kreileder <redacted> --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 4f0c3bd..a2838c3 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -7482,7 +7482,7 @@ sub git_feed { return if ($cgi->request_method() eq 'HEAD'); # header variables - my $title = "$site_name - $project/$action"; + my $title = to_utf8($site_name) . " - " . to_utf8($project) . "/$action"; my $feed_type = 'log'; if (defined $hash) { $title .= " - '$hash'";--
Thanks. With the minor nit of prefixing subject with subsystem designation, i.e. with "gitweb: " -- ACK. -- Jakub Narębski