Thread (7 messages) flat view 7 messages, 4 authors, 2016-06-15

Re: what are the chances of a 'pre-upload' hook?

From: Sitaram Chamarty <hidden>
Date: 2016-06-15 22:52:31

On Fri, Nov 25, 2011 at 8:46 AM, Sitaram Chamarty [off-list ref] wrote:
(...and/or a post-upload hook)

Has this ever come up?
Sorry for the google-fu fail and for replying to my own post.
http://git.661346.n2.nabble.com/Removal-of-post-upload-hook-td4394312.html
is the longest thread I (later) found.

The quick summary, in the words of Jeff (second post in that link) is:
"Because [upload]-pack runs as the user who is [fetching], not as the
repository owner. So by convincing you to [fetch from] my repository
in a multi-user environment, I convince you to run some arbitrary code
of mine."

My contention (today) is:

  - you're already taking that risk for push
  - so this would add a new risk only for people who fetch but don't push
  - which, I submit, is a very small (if not almost empty) set of people

I may be wrong but I imagine shared environments are those where
almost everyone will push at least once in a while.  It's a closed
group of people, probably all developers, etc etc etc...

Thanks for listening.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help