Thread (5 messages) 5 messages, 2 authors, 2016-06-15

Re: [PATCH] Compile fix for MSVC: Move poll.h out of sys-folder

From: Vincent van Ravesteijn <hidden>
Date: 2016-06-15 22:52:30

This looks strange to me. vcbuild/include/poll.h will only prevent the
correct header from being included, while compiling an linking against
compat/win32/poll.[co]... That seems dangerous to me, because the
interface might be declared differently.

Instead, I think compat/vcbuild/include/poll.h should be removed,
Yes, it should just be removed. Having poll.h in the sys directory was 
wrong and the patch I sent was needed to make 0f77dea compile.

Your patch is indeed necessary to compile later revisions as well.
I still can't build Junio's master,
due to sys/resource.h missing. This comes from ebae9ff ("compat: add
missing #include<sys/resource.h>"), and is only guarded against
MinGW, not MSVC...
The fix for this is already in 'next' now. So, with your patch, 'next' 
does compile.

Vincent
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help