Re: [PATCH v2] Makefile: add option to disable automatic dependency generation
From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:52:30
On Fri, Nov 18, 2011 at 4:58 PM, Jonathan Nieder [off-list ref] wrote:
Now that the COMPUTE_HEADER_DEPENDENCIES feature is turned on automatically for compilers that support it (see v1.7.8-rc0~142^2~1, 2011-08-18), there is no easy way to force it off. For example, setting COMPUTE_HEADER_DEPENDENCIES to the empty string in config.mak just tells the makefile to treat it as undefined and run a test command to see if the -MMD option is supported. So allow setting COMPUTE_HEADER_DEPENDENCIES=no to explicitly force the feature off. The new semantics: - "yes" means to explicitly enable the feature - "no" means to disable it - "auto" means to autodetect The default is still "auto". Any value other than these three will cause the build to error out with a descriptive message so typos and stale settings in config.mak don't result in mysterious behavior. Makefile:1278: *** please set COMPUTE_HEADER_DEPENDENCIES to yes, no, or auto (not "1"). Stop. So now when someone using a compiler without -MMD support reports trouble building git, you can reproduce it by running "make COMPUTE_HEADER_DEPENDENCIES=no". Suggested-by: Nguyễn Thái Ngọc Duy <redacted> Improved-by: Junio C Hamano [off-list ref] Signed-off-by: Jonathan Nieder <redacted>
Tested-by: Nguyễn Thái Ngọc Duy <redacted> -- Duy