Re: [PATCH/RFC] Restore line limit option in post-receive-email
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:28
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH/RFC] Restore line limit option in post-receive-email · Cheng Leong <hidden>
Cheng Leong [off-list ref] writes:
quoted hunk
The hooks.emailmaxlines config currently has no effect. Stop prep_for_email from clobbering the already-initialized maxlines variable in the contrib/hooks/post-receive-email example. Signed-off-by: Cheng Leong <redacted> --- contrib/hooks/post-receive-email | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index ba077c1..ac2e0ed 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email@@ -85,7 +85,6 @@ prep_for_email() oldrev=$(git rev-parse $1) newrev=$(git rev-parse $2) refname="$3" - maxlines=$4 # --- Interpret # 0000->1234 (create)
Umm, there is another place where $maxlines is used without merit. Shouldn't we do something like below as well? contrib/hooks/post-receive-email | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ba077c1..e27ca3c 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email@@ -743,6 +743,6 @@ else while read oldrev newrev refname do prep_for_email $oldrev $newrev $refname || continue - generate_email $maxlines | send_mail + generate_email | send_mail done fi