Re: [msysGit] Re: [PATCHv2] Compile fix for MSVC

Hi kusma,

On Tue, 1 Nov 2011, Erik Faye-Lund wrote:

On Tue, Nov 1, 2011 at 1:09 AM, Johannes Schindelin
[off-list ref] wrote:

quoted

On Mon, 31 Oct 2011, Junio C Hamano wrote:

quoted

Thanks. The patch looks good from a POSIX person's point of view, and 
I do not immediately see how this would break other variants of 
Windows build at least from the code inspection.

As my virtual machine still ran the test suite after my latest 
rebasing merge when I left work, I could not test the MSVC stuff just 
yet. I wanted to do that tomorrow and either merge or come back with 
suggestions.

I've applied the patches to 'devel', verified that the result builds, 
and pushed it out.

I've applied your patches and made up commit messages. So far, I only 
tested with MSVCE 9.0 (AKA Express 2008) before running out of time. 
Please have a look at the commits (since I could build a git.exe with the 
correct version, I felt comfortable enough to push out to 'devel').

Maybe if someone donates Jenkins resources, we could make an automatic 
branch in the future that has git.sln in it (similar to the 'html' branch 
in git.git).

Ciao,
Dscho