Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Fix a typo in line 117 of git-gui/lib/sshkeys.tcl.

From: Pat Thoyts <hidden>
Date: 2016-06-15 22:52:21

Erik Faye-Lund [off-list ref] writes:
Thanks for re-posting inline and with a sign-off. But there's still a
few minor nits:

2011/10/30 Dejan Ribič [off-list ref]:
quoted
"succeded" changed to "succeeded".
We write commit messages in imperative mood, so this should be
something like 'change "succeded" to "succeeded"' instead. This is
documented in Documentation/SubmittingPatches.
quoted
modified:   git-gui/lib/sshkey.tcl
We don't normally include a list of changed files in the commit
message; the diffstat already provides that information.
The change is fine so I've applied this to the git-gui repository with a
fixed commit message. Thank you.

git-gui is hosted separately and merged into git-core at intervals so
the development version of git-gui is in fact hosted at 
git://repo.or.cz/git-gui.git although patches against the git-core
version seldom pose a problem to apply and are gratefully received.
(git am -p2 usually fixes them).

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help