Re: git slow over https

Thanks for the pointer. Doing it this way fixes things for me. I'll
send a patch soon. I'd appreciate it if you could check it quicky.

Best,
 Mika

On Fri, Oct 28, 2011 at 20:28, Daniel Stenberg [off-list ref] wrote:

On Fri, 28 Oct 2011, Mika Fischer wrote:

quoted

1) What's the purpose of the select in http.c:673? Can it be removed?
2) If it serves a useful purpose, what can be the reason that it hurts
performance so much in my case?

The purpose must be to avoid busy-looping in case there's nothing to read.

It should probably use curl_multi_fdset [1] to get a decent set to wait for
instead so that it'll return fast if there is pending data. The timeout for
select can in fact also get extended with the use of curl_multi_timeout [2].

1 = http://curl.haxx.se/libcurl/c/curl_multi_fdset.html
2 = http://curl.haxx.se/libcurl/c/curl_multi_timeout.html

--

 / daniel.haxx.se