Re: [msysGit] [PATCH] git grep: be careful to use mutices only when they are initialized

Hi Tay,

On Wed, 26 Oct 2011, Tay Ray Chuan wrote:

On Wed, Oct 26, 2011 at 1:25 AM, Johannes Schindelin
[off-list ref] wrote:

quoted

Rather nasty things happen when a mutex is not initialized but locked 
nevertheless. Now, when we're not running in a threaded manner, the 
mutex is not initialized, which is correct. But then we went and used 
the mutex anyway, which -- at least on Windows -- leads to a hard 
crash (ordinarily it would be called a segmentation fault, but in 
Windows speak it is an access violation).

This problem was identified by our faithful tests when run in the 
msysGit environment.

May I ask which test are you talking about specifically?

It is t7810.

I ask as I'm curious how this is triggered; git-grep works fine for me 
so far (1.7.6.msysgit.0.584.g2cbf)

That did not expose the error. The problem is exposed in msysGit's 'devel' 
branch, though.

Ciao,
Johannes