Re: [PATCH 1/3] MSVC: Compile fix by not including sys/resources.h
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:18
quoted
... Subject: [PATCH 1/3] MSVC: Compile fix by not including sys/resources.h Content-Type: text/plain; charset=ISO-8859-1; format=flowed
........................................................^^^^^^ Could you refrain from doing that? It breaks the patch text. Vincent van Ravesteijn [off-list ref] writes:
Fix compilation when compiling with MSVC because sys/resource.h is not available. This patch causes a number of other headerfiles that are not available to be excluded as well. Signed-off-by: Vincent van Ravesteijn <redacted>
Instead of current
#ifndef mingw32 is the only one that is strange
... everything for systems that is not strainge ...
#else
... include mingw specific tweaks ...
#endif
#ifdef msvc is also strange
... include msvc specific tweaks ...
#endif
it turns things around and says what it wants to achieve in a more direct
way, i.e.
#if mingw32
#include "compat/mingw.h"
#elif msvc
#include "compat/msvc.h"
#else
... all the others ...
#endif
which makes it look simpler.