Re: [RFC 09/13] new_branch(): verify that new branch name is a valid full refname
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:18
mhagger@alum.mit.edu writes:
From: Michael Haggerty <redacted> Signed-off-by: Michael Haggerty <redacted> --- Is it possible to omit the REFNAME_ALLOW_ONELEVEL option from this call?
I _think_ it takes an unadorned branch name, so the most prudent would be to check the result of prefixing "refs/heads/" to *name with REFNAME_FULL.
quoted hunk
fast-import.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/fast-import.c b/fast-import.c index 8d8ea3c..51cf898 100644 --- a/fast-import.c +++ b/fast-import.c@@ -722,7 +722,7 @@ static struct branch *new_branch(const char *name) if (b) die("Invalid attempt to create duplicate branch: %s", name); - if (check_refname_format(name, REFNAME_ALLOW_ONELEVEL)) + if (check_refname_format(name, REFNAME_FULL|REFNAME_ALLOW_ONELEVEL)) die("Branch name doesn't conform to GIT standards: %s", name); b = pool_calloc(1, sizeof(struct branch));