Re: [GUILT] handle branches with slashes in guilt-graph

Junio C Hamano [off-list ref] writes:

Andreas Schwab [off-list ref] writes:

quoted

Per Cederqvist [off-list ref] writes:

quoted

Avoid sed errors when the branch name contains a slash.

Signed-off-by: Per Cederqvist <redacted>

--- /usr/bin/guilt-graph~	2011-01-25 20:15:50.000000000 +0100
+++ /usr/bin/guilt-graph	2011-10-18 12:30:31.000000000 +0200

@@ -37,9 +37,10 @@ disp "digraph G {"

 current="$top"

+safebranch=`echo "$branch"|sed 's%/%\\\\/%g'`
 while [ "$current" != "$base" ]; do
 	pname=`git show-ref | sed -n -e "
-/^$current refs\/patches\/$branch/ {
+/^$current refs\/patches\/$safebranch/ {

Alternatively, you could change the delimiter to `,':

  \,^$current refs/patches/$branch, {

Isn't a comma still valid character in a branch name?

I suggested the comma because it is already used by the next sed
command, so that won't be a regression.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."