Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:52:17
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns · SZEDER Gábor <hidden>
- 2016-06-15 · Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns · Jeff King <hidden>
- 2016-06-15 · [PATCH 3/3] completion: match ctags symbol names in grep patterns · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/3] completion: match ctags symbol names in grep patterns · Matthieu Moy <hidden>
Junio C Hamano wrote:
Perhaps something like this is in order?
[...]
quoted hunk ↗ jump to hunk
+++ b/Makefile@@ -2127,17 +2127,25 @@ po/git.pot: $(LOCALIZED_C) pot: po/git.pot +git_check = $(shell git ls-files >/dev/null 2>&1; echo $$?) +ifeq ($(git_check),0) +FIND_SOURCE_FILES = git ls-files '*.[hcS]' +else +FIND_SOURCE_FILES = $(FIND) . \( -name .git -type d -prune \) \ + -o \( -name '*.[hcS]' -type f -print \) +endif
Neat. I'd prefer something like FIND_SOURCE_FILES = \ git ls-files '*.[hcS]' 2>/dev/null || \ $(FIND) . -name .git -prune -o -name '*.[hcS]' -type f -print that avoid punishing people who were using the makefile for some purpose unrelated to tags and cscope, though. ;)