Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 00/14] Tidying up references code

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:17

mhagger@alum.mit.edu writes:
From: Michael Haggerty <redacted>

Patch series re-rolled against v4 of "Provide API to invalidate refs
cache"...
Thanks; queued (but not pushed out yet).
BTW, whenever I add comments to existing code, it is just an attempt
to record information that I have inferred from reverse-engineering.
Thanks again. I often find me scratching head while reading other people's
code, long after I reviewed (or read other's reviews) and accepted their
patches.  It often is not the lack of review that caused undercommented
code to get in my tree. During the review process, the issue the code is
trying to solve is so fresh in everybody's mind, that certain things do
not need to be explained to be understood. But that kind of memory
eventually fades and only the code remains.

It is a rather unfortunate result of the human nature that the next person
who touches that code is in the best position to find out what aspect of
the code is hard to understand and deserves comment.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help