Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH/RFC] gitweb: add the ability to show side-by-side diff on commitdiff.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:16

Kato Kazuyoshi [off-list ref] writes:
On Mon, Oct 17, 2011 at 10:51 AM, Junio C Hamano [off-list ref] wrote:
quoted
I think a better organization would be

 [1/2] change code so that $diff_class does not have leading SP
      optionally catch a case where $diff_class stays empty as an error?
I think we don't have to treat empty $diff_class as an error because
$diff_class will be an empty when $line is around modification
(ex. foo or quux).

  foo
- bar
+ baz
  quuz
Ok. then even though class="diff " is not any different from class="diff",
I have to say generated html output becomes aesthetically less nice with
this change; we may want to do something about it _iff_ it does not take
too much change, but as I said I do not care too much about it.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help