Re: [PATCH 1/2] daemon: add tests
From: Jeff King <hidden>
Date: 2016-06-15 22:52:16
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 1/2] daemon: add tests · Brian Gernhardt <hidden>
- 2016-06-15 · Re: [PATCH 1/2] daemon: add tests · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH 1/2] daemon: add tests · Clemens Buchacher <hidden>
- 2016-06-15 · Re: [PATCH 1/2] daemon: add tests · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH 1/2] daemon: add tests · Junio C Hamano <hidden>
On Mon, Oct 17, 2011 at 12:11:15AM +0200, Clemens Buchacher wrote:
The semantics of the git daemon tests are similar to the http transport tests. In fact, they are only a slightly modified copy of t5550, plus the newly added remote error tests. All daemon tests will be skipped unless the environment variable GIT_TEST_DAEMON is set.
Thanks, it's nice to have some tests. Overall, some of the tests feel a little silly, because the results should be exactly the same as fetching or pushing a local repository (so the "set-head" thing, for example, really has little to do with git-daemon). At the same time, maybe it's a good thing to re-confirm that the results really are the same. :)
quoted hunk ↗ jump to hunk
diff --git a/t/lib-daemon.sh b/t/lib-daemon.sh new file mode 100644 index 0000000..30a89ea --- /dev/null +++ b/t/lib-daemon.sh@@ -0,0 +1,52 @@ +#!/bin/sh + +if test -z "$GIT_TEST_DAEMON" +then + skip_all="Daemon testing disabled (define GIT_TEST_DAEMON to enable)" + test_done +fi + +LIB_DAEMON_PORT=${LIB_DAEMON_PORT-'8121'}
I assume you picked this arbitrarily to be LIB_HTTPD_PORT+10. It's fine to have a default, but note that each of the httpd tests actually defaults the port to their test number, so they can be run in parallel. So that would be:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/t/t5570-git-daemon.sh@@ -0,0 +1,148 @@ +#!/bin/sh + +test_description='test fetching over git protocol' +. ./test-lib.sh + +. "$TEST_DIRECTORY"/lib-daemon.sh +start_daemon
LIB_DAEMON_PORT=${LIB_DAEMON_PORT-'5570'}
here.