Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 2/2] bundle: add parse_bundle_header() helper function

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:15

Phil Hord [off-list ref] writes:
On Thu, Oct 13, 2011 at 6:35 PM, Junio C Hamano [off-list ref] wrote:
quoted
Move most of the code from read_bundle_header() to parse_bundle_header()
that takes a file descriptor that is already opened for reading, and make
the former responsible only for opening the file and noticing errors.
...
quoted
 * It generally is a bad practice to base a non-RFC patch on an RFC one,
  but in any case here is how I would do the is_bundle() helper.
I didn't label it RFC,...
I was referring to the fact that _my_ 2/2 you are responding to was meant
to be applied on top of _my_ 1/2 that was marked as RFC.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help