Thread (13 messages) flat view 13 messages, 2 authors, 2016-06-15

Re: [PATCH 2/9] completion: optimize refs completion

From: SZEDER Gábor <hidden>
Date: 2016-06-15 22:52:15

On Sat, Oct 08, 2011 at 04:54:36PM +0200, SZEDER Gábor wrote:
So, add a specialized variant of __gitcomp() that only deals with
possible completion words separated by a newline 
quoted hunk ↗ jump to hunk
@@ -2635,7 +2659,7 @@ _git ()
 			"
 			;;
 		*)     __git_compute_porcelain_commands
-		       __gitcomp "$__git_porcelain_commands $(__git_aliases)" ;;
+		       __gitcomp_nl "$__git_porcelain_commands $(__git_aliases)" ;;
 		esac
 		return
 	fi
Oops, this last hunk is wrong.

I made the thinko that $__git_porcelain_commands is NL-separated and
the output of __git_aliases() is NL-separated, so we can pass the two
together to the new __gitcomp_nl() function.  But of course not,
because the SP between the two joins the last command and the first
alias.

I will resend in the evening with this hunk removed and the commit
message updated.


Gábor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help