Re: [PATCH 05/14] clear_ref_list(): rename from free_ref_list()
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:15
mhagger@alum.mit.edu writes:
From: Michael Haggerty <redacted> Rename the function since it doesn't actually free the array object that is passed to it.
The commit log message correctly refers to the "array-ness" of the object being cleared. Needs retitling the patch to match.
quoted hunk
Signed-off-by: Michael Haggerty <redacted> --- refs.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)diff --git a/refs.c b/refs.c index c466fcd..a2e48e4 100644 --- a/refs.c +++ b/refs.c@@ -149,7 +149,7 @@ static struct ref_entry *current_ref; static struct ref_array extra_refs; -static void free_ref_array(struct ref_array *array) +static void clear_ref_array(struct ref_array *array) { int i; for (i = 0; i < array->nr; i++)@@ -162,14 +162,14 @@ static void free_ref_array(struct ref_array *array) static void clear_cached_packed_refs(struct cached_refs *refs) { if (refs->did_packed) - free_ref_array(&refs->packed); + clear_ref_array(&refs->packed); refs->did_packed = 0; } static void clear_cached_loose_refs(struct cached_refs *refs) { if (refs->did_loose) - free_ref_array(&refs->loose); + clear_ref_array(&refs->loose); refs->did_loose = 0; }@@ -256,7 +256,7 @@ void add_extra_ref(const char *refname, const unsigned char *sha1, int flag) void clear_extra_refs(void) { - free_ref_array(&extra_refs); + clear_ref_array(&extra_refs); } static struct ref_array *get_packed_refs(const char *submodule)