Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 5/6] Convert simple init_pathspec() cases to parse_pathspec()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:14

I gave a cursory look up to this one. I didn't read 4/6 very carefully
though.

I think teaching the users of "raw[]" field of "struct pathspec" to use
corresponding "items[]" element should come before this series (up to
5/6). After that, once parse_pathspec() API stabilizes, we should teach
users of get_pathspec() to get and pass around "struct pathspec" and when
we reach the point where we can get rid of use of "raw[]" field (the field
itself can stay to serve as a debugging aid if we choose to), everybody
that uses pathspec would be ready to start taking more magic pathspecs.

Having said that, I think the series itself is going in the right
direction.

Thanks for working on this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help