Re: [PATCH v3 1/7] invalidate_ref_cache(): rename function from invalidate_cached_refs()
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:14
Michael Haggerty [off-list ref] writes:
It is the cache that is being invalidated, not the references. Signed-off-by: Michael Haggerty <redacted> ---
quoted hunk
diff --git a/refs.c b/refs.c index 9911c97..120b8e4 100644 --- a/refs.c +++ b/refs.c@@ -202,7 +202,7 @@ static struct cached_refs *get_cached_refs(const char *submodule) return refs; } -static void invalidate_cached_refs(void) +static void invalidate_ref_cache(void) { struct cached_refs *refs = cached_refs; while (refs) {
If you call the operation "invalidate ref_cache", shouldn't the data structure that holds that cache also be renamed to "struct ref_cache" from "struct "cached_refs" at the same time?