Re: [PATCH v2 1/7] invalidate_ref_cache(): rename function from invalidate_cached_refs()
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:13
Michael Haggerty [off-list ref] writes:
It is the cache that is being invalidated, not the references. Signed-off-by: Michael Haggerty <redacted> ---
Although I think one can say "ref cache is the container for cached refs" and invalidating the "ref cache" as the container and invalidating the "cached refs" as a collection mean essentially the same thing, probably the new name makes more sense.
quoted hunk ↗ jump to hunk
refs.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)diff --git a/refs.c b/refs.c index 2cb93e2..56e4254 100644 --- a/refs.c +++ b/refs.c@@ -223,7 +223,7 @@ static struct cached_refs *get_cached_refs(const char *submodule) return refs; } -static void invalidate_cached_refs(void) +static void invalidate_ref_cache(void) { struct cached_refs *refs = cached_refs; while (refs) {@@ -1212,7 +1212,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt) ret |= repack_without_ref(refname); unlink_or_warn(git_path("logs/%s", lock->ref_name)); - invalidate_cached_refs(); + invalidate_ref_cache(); unlock_ref(lock); return ret; }@@ -1511,7 +1511,7 @@ int write_ref_sha1(struct ref_lock *lock, unlock_ref(lock); return -1; } - invalidate_cached_refs(); + invalidate_ref_cache(); if (log_ref_write(lock->ref_name, lock->old_sha1, sha1, logmsg) < 0 || (strcmp(lock->ref_name, lock->orig_ref_name) && log_ref_write(lock->orig_ref_name, lock->old_sha1, sha1, logmsg) < 0)) {