Re: [PATCH da/difftool-mergtool-refactor] Makefile: fix permissions of mergetools/ checked out with permissive umask

On Oct 9, 2011, at 4:43 AM, Jonathan Nieder [off-list ref] wrote:

Jonathan Nieder wrote:

quoted

---

[...]

quoted

Since debian/rules install is run as root, the default is for tar to
act as thought --preserve-permissions were passed

I should have said: "when 'make install' is run as root, ...".

Typically people building git for private use would run "make install"
as root when installing to /usr/local, but as an unprivileged user
when installing to $HOME.  The RPM packaging runs "make install"
without special privileges and the Debian packaging runs it as (fake)
root, iirc.

Sorry for the lack of clarity.

thanks. I agree that the tar is overkill. I think I copied that snippet from templates/makefile. does that have the same bug?
-- 
    David (mobile)