Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH] git-difftool: allow skipping file by typing 'n' at prompt

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:10

Possibly related (same subject, not in this thread)

Phil Hord [off-list ref] writes:
On Tue, Oct 4, 2011 at 11:25 AM, Junio C Hamano [off-list ref] wrote:
quoted
I think I've seen this done as: "do this? [Y/n]" elsewhere.

Not telling you what to do, but trying to feel what others may think.
I think so, too.  The [y]/n syntax is not clear enough for me to
confidently know what the default value will be.
One downside of "do this [Y,n,m,o,p,q]? " is that it limits us to
lowercase responses, which means we cannot assign 'q' for quitting from
the innermost nested context and assign 'Q' for quitting from the whole
interactive loop (e.g. "git add -p").

    "do this [y,n,m,o,p,q] (default=y)? "

may have been a better choice in hindsight.

No matter what we end up doing, let's try to be consistent.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help