Re: [PATCH v2] gitk: Show patch for initial commit
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:10
Marcus Karlsson [off-list ref] writes:
quoted
Also the gitk should be mentioned in the man-page for git-config log.showroot. The current description of this option seems suboptimal because it explains how it used to be, which is not really relevant: log.showroot If true, the initial commit will be shown as a big creation event. This is equivalent to a diff against an empty tree. Tools like git-log(1) or git- whatchanged(1), which normally hide the root commit will now show it. True by default. This could be changed to: If true (the default), the root commit will be shown as a big creation event --- a diff against an empty tree. This diff can be very large for a project which was imported into git after some development history. If log.showroot is false tools like git-log(1), git-whatchanged(1), or gitk(1) will not display the added files.I agree, but that feels like something that could be made into a separate patch. Or should I include that too?
Please make it a separate patch. A patch to Documentation/config.txt should go to git.git project, but gitk patch (whose "diff --git" line should read "diff --git a/gitk b/gitk") should go first to gitk.git project and then merged to my tree.