Re: [PATCH] transport: do not allow to push over git:// protocol
From: Jeff King <hidden>
Date: 2016-06-15 22:52:09
On Mon, Oct 03, 2011 at 08:44:22PM +1100, Nguyen Thai Ngoc Duy wrote:
quoted
GitHub uses it to make nice messages: $ git push origin fatal: remote error: You can't push to git://github.com/gitster/git.git Use git@github.com:gitster/git.git We should maybe do something like the patch below:Jonathan also mentions another patch http://article.gmane.org/gmane.comp.version-control.git/182536
Yeah, I was just reading that. Sorry, I should have read the rest of the thread more carefully. :)
quoted
1. There is some information leakage there. In particular, one can tell the difference now between "repo does not exist" and "receive-pack is not turned on". Personally, I think the tradeoff to have actual error messages is worth it. HTTP has had real error codes for decades, and I don't think anybody is too up-in-arms that I can probe which pages are 404, and which are 401.To me, just "<service>: access denied" is enough. Not particularly friendly but should be a good enough clue.
Yeah, maybe. Certainly it's better than "the remote end hung up unexpectedly". However, the leakage is still there. You would get "the remote hung up" for no-such-repo, and "access denied" for this. Or were you just proposing that _all_ errors give "access denied". Certainly it's better than just hanging up, too, and there is no leakage there. It might be nice to default to that, and let sites easily enable friendlier messages, though. -Peff