Thread (5 messages) flat view 5 messages, 3 authors, 2016-06-15

Re: [PATCH] gitweb: Add js=1 before an URI fragment to fix line number links

From: Peter Stuge <hidden>
Date: 2016-06-15 22:52:07

Possibly related (same subject, not in this thread)

Junio C Hamano wrote:
quoted
I thought subject together with change would be clear enough. :)

quoted
Explanation of what you are fixing is totally lacking.
The subject sums it up, if briefly.
... Sorry, that is not what I meant.

You don't have to explain these to *me* specifically as a response
to this thread. What I meant was that your patch should have these
necessary descriptions in its proposed commit log message.
IMO not so neccessary if one knows a little web and javascript, which
is probably likely for a gitweb change..

It's a simple fix of links broken by manual URI manipulation that
didn't consider fragments. Is the subject description really not
enough?


//Peter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help