Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/5] git-p4 tests: refactor, split out common functions

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:04

Pete Wyckoff [off-list ref] writes:
Yes, this is all very shoddy, and I suspect that I don't need the
initial kill_p4d as long as the other tests fail nicely.

But your point about killing the _wrong_ p4d is good.  But p4d
isn't friendly like other daemons that will drop a pid file for
help in future cleanup.  I can run it without the "-d", in which
case it does not daemonize.  Then I should be able to use shell
job control to kill off the one I started, hopefully.
Yeah, something like

	: start
	p4d &
        echo $! >$pidfile

        : stop
	while kill -0 $pidfile
        do
	        kill $pidfile
                sleep 1
	done
Finding an unused port is also a pain.
I think the way t55xx series assign LIB_HTTPD_PORT is an acceptable
compromise.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help