Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] git-mergetool: check return value from read

From: Andrew Ardill <hidden>
Date: 2016-06-15 22:52:04

On 20 September 2011 10:41, Junio C Hamano [off-list ref] wrote:
Jay Soffian [off-list ref] writes:
quoted
quoted
I suspect that it would be more consistent with 6b44577 (mergetool: check
return value from read, 2011-07-01), which this patch is a follow-up to,
to do:

     read answer || return 1

here.
Thanks, sorry I missed that.
Thank _you_ for spotting these unchecked "read"s.  Will queue.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
I got hit by the ctrl+c bug while using mergetool just the other day.
Thanks for the fix :)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help