Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] git-web--browse: invoke kfmclient directly

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:52:04

Jeff King [off-list ref] writes:
Yeah. Doing:

  eval '$browser_cmd'

will do the whitespace-breaking we want, but it won't interpret actual
shell magic characters, which we need in order to be compatible with
other parts of git (which typically use "sh -c ..."). E.g.:

  foo=worked
  browser_cmd='echo $foo'
Yikes, I forgot that we do that. You are right.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help