Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH v3] git svn dcommit: new option --interactive.

From: Eric Wong <hidden>
Date: 2016-06-15 22:52:03

Carlos Martín Nieto [off-list ref] wrote:
On Fri, 2011-09-16 at 23:02 +0200, Frédéric Heitzmann wrote:
quoted
Allow the user to check the patch set before it is commited to SNV. It is
Typo: SNV -> SVN
Thanks, fixed locally
My perl-foo isn't strong enough to properly review the rest.
I also squashed the following cleanup:
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -802,7 +802,6 @@ sub cmd_dcommit {
 	if (defined $_interactive){
 		my $ask_default = "y";
 		foreach my $d (@$linear_refs){
-			print "debug : d = $d\n";
 			my ($fh, $ctx) = command_output_pipe(qw(show --summary), "$d");
 			while (<$fh>){
 				print $_;

Otherwise things good to me.  Acked and pushed out to master of
git://bogomips.org/git-svn.git
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help