Re: [PATCH] Un-static gitmkstemps

Brian Gernhardt [off-list ref] writes:

It may not be used in most builds, but it's used via a #ifdef in
git-compat-util.h  ...

Hmm, do you mean "#define", not "#ifdef", specifically, this:

    maint:git-compat-util.h:#define mkstemps gitmkstemps

... Also, making it static makes a -Wall compile fail
since it's not used in the file without NO_MKSTEMPS.

Your alternative of not defining on builds without NO_MKSTEMPS is better,
and probably even better yet, it would make sense to move the definition
of git_mkstemps() out of wrapper.c and have it somewhere in compat/, just
like the way in which compat/qsort.c defines git_qsort() that is used as a
replacement for qsort() via #define on systems that lack it.