Re: [PATCH 7/7] run_hook: use argv_array API

Jeff King [off-list ref] writes:

On Wed, Sep 14, 2011 at 11:54:11AM -0700, Junio C Hamano wrote:

quoted

Jeff King [off-list ref] writes:

quoted

@@ -609,26 +610,23 @@ int finish_async(struct async *async)
 int run_hook(const char *index_file, const char *name, ...)
 {
 	struct child_process hook;
-	const char **argv = NULL, *env[2];
+	struct argv_array argv = ARGV_ARRAY_INIT;
+	const char *p, *env[2];

Given that in argv-array.h you define it as

    #define ARGV_ARRAY_INIT { empty_argv, 0, 0 };

the above will introduce decl-after-stmt.

Oops. Can you squash in removing the semicolon from the macro
definition?

Yes, I did. Thanks.