Thread (5 messages) flat view 5 messages, 2 authors, 2016-06-15

Re: [PATCH/RFC 1/2] format-patch: demonstrate that color.ui=always produces colorized patches

From: Jeff King <hidden>
Date: 2016-06-15 22:52:01

On Mon, Sep 12, 2011 at 11:56:55PM +0800, Pang Yan Han wrote:
Hi, I don't know if I actually understand the naming convention for tests
correctly here, so I used the next available number for the last 2 digits.

 t/t4051-format-patch-color.sh |   23 +++++++++++++++++++++++
Usually we would try to keep format-patch tests clustered numerically,
but it seems the t40* space has gotten quite filled up and fragmented.
So I think where you added it is fine (and if somebody cares to
reorganize tests, they can do so later).

Often if there is only one or two tests to add, it is more logical to
add to an existing script. However, I think in this case, starting a new
script to check how format-patch handles various config features
(including color) makes sense. Maybe it makes sense to call it
"format-patch-config" instead, and set the description to something like
"check that format-patch does not respect porcelain config".

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help