Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] send-email: add option -h

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:59

Possibly related (same subject, not in this thread)

Clemens Buchacher [off-list ref] writes:
Most other git commands print a synopsis when passed -h. Make
send-email do the same.

Signed-off-by: Clemens Buchacher <redacted>
...
+my $help;
+my $rc = GetOptions("help|H|h" => \$help,
I do not think what the patch aims to do is wrong per-se, but

 $ git send-email --help

already shows the full documentation, and I find it is misleading to say
"help|H|h" here to pretend as if a long-help is triggered with this
command. For that matter, do we have any other place that accept -H for
help?

IOW, shouldn't this line be this instead?
+my $rc = GetOptions("h" => \$help,
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help