Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:51:58
Subsystem:
documentation, the rest · Maintainers:
Jonathan Corbet, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] shell portability: Use sed instead of non-portable variable expansion · Naohiro Aota <hidden>
- 2016-06-15 · Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion · Johannes Sixt <hidden>
- 2016-06-15 · Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] shell portability: Use sed instead of non-portable variable expansion · Johannes Sixt <hidden>
Johannes Sixt [off-list ref] writes:
quoted hunk
Am 9/5/2011 9:09, schrieb Junio C Hamano:quoted
By the way, t9010 uses ${#parameter} (strlen) which is bashism we forbid, and it needs to be rewritten (David CC'ed).Actually, no. It is perfectly valid POSIX. So we would need this patch.--- 8< ---From: Johannes Sixt <redacted> Subject: [PATCH] CodingGuidelines: ${#parameter} is POSIX and should be allowed See http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02. Signed-off-by: Johannes Sixt <redacted> ---
I would prefer to play it safe at least for now, especially before 1.7.7 ships. Documentation/CodingGuidelines | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index fe1c1e5..594fb76 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines@@ -52,7 +52,7 @@ For shell scripts specifically (not exhaustive): - No shell arrays. - - No strlen ${#parameter}. + - No strlen ${#parameter} (even though it is in POSIX). - No pattern replacement ${parameter/pattern/string}.